Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes to metadata.db #7

Merged
merged 2 commits into from
Feb 11, 2024
Merged

small fixes to metadata.db #7

merged 2 commits into from
Feb 11, 2024

Conversation

Milotrince
Copy link
Member

No description provided.

@Milotrince Milotrince requested a review from KeplerC February 11, 2024 21:02
@KeplerC
Copy link
Collaborator

KeplerC commented Feb 11, 2024

A quick question: if changed to TEXT, do we need to str() all the fields?

@Milotrince
Copy link
Member Author

I don't think so, but should probably try first. I think the only difference is that TEXT is assumed utf-8 encoding while BLOB could be anything. It's helpful when reading the file

@KeplerC
Copy link
Collaborator

KeplerC commented Feb 11, 2024

sounds good. merged!

@KeplerC KeplerC merged commit 2ba7f04 into main Feb 11, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants